Avoid bounds checking where it is safe to do so #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efaulhaber
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #74 +/- ##
==========================================
+ Coverage 88.13% 88.15% +0.01%
==========================================
Files 15 15
Lines 489 498 +9
==========================================
+ Hits 431 439 +8
- Misses 58 59 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
svchb
requested changes
Nov 15, 2024
svchb
approved these changes
Nov 15, 2024
LasNikas
reviewed
Nov 18, 2024
LasNikas
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR and trixi-framework/TrixiParticles.jl#656 yield a ~3% speedup on a Threadripper 3990X and a ~42% speedup on an Nvidia H100. Interestingly, there is no difference on an Nvidia RTX 3090 with FP64 (probably limited by something else), but it benefits even more from inbounds on FP32 with a 60% speedup.
Not all bounds checks could be safely removed. See #79 for a completely exception-free kernel. The additional speedup is about 2% and can be neglected.